Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zipapp section to indicate where past virtualenv.pyz can be found #2081

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Update zipapp section to indicate where past virtualenv.pyz can be found #2081

merged 2 commits into from
Apr 20, 2021

Conversation

goodwillcoding
Copy link
Contributor

@goodwillcoding goodwillcoding commented Mar 9, 2021

Addresses some of the concerns in #2080

Thanks for contributing, make sure you address all the checklists (for details on how see

development documentation)!

  • ran the linter to address style issues (tox -e fix_lint)
  • wrote descriptive pull request text
  • ensured there are test(s) validating the fix
  • added news fragment in docs/changelog folder
  • updated/extended the documentation

@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #2081 (2139a20) into main (742e145) will decrease coverage by 0.59%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2081      +/-   ##
==========================================
- Coverage   93.67%   93.08%   -0.60%     
==========================================
  Files          88       88              
  Lines        4380     4380              
==========================================
- Hits         4103     4077      -26     
- Misses        277      303      +26     
Flag Coverage Δ
tests 93.08% <ø> (-0.60%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/virtualenv/util/path/_pathlib/__init__.py 30.30% <0.00%> (-63.64%) ⬇️
...ualenv/create/via_global_ref/builtin/pypy/pypy3.py 94.87% <0.00%> (-5.13%) ⬇️
src/virtualenv/info.py 95.00% <0.00%> (-5.00%) ⬇️
src/virtualenv/seed/embed/base_embed.py 96.22% <0.00%> (-1.89%) ⬇️
src/virtualenv/discovery/py_info.py 94.78% <0.00%> (-0.31%) ⬇️
.../create/via_global_ref/builtin/cpython/cpython2.py 98.50% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 742e145...2139a20. Read the comment docs.

Copy link
Contributor

@gaborbernat gaborbernat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaborbernat gaborbernat merged commit f198a65 into pypa:main Apr 20, 2021
@gaborbernat
Copy link
Contributor

Released via https://pypi.org/project/virtualenv/20.4.4/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants